Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive ArrowPrimitiveType for Decimal128Type and Decimal256Type (#2637) #2833

Merged
merged 1 commit into from Oct 6, 2022

Conversation

tustvold
Copy link
Contributor

@tustvold tustvold commented Oct 6, 2022

Which issue does this PR close?

Part of #2637

Rationale for this change

This allows creating PrimitiveArrays with decimal types, subsequent PRs will flesh out support for this, before switching over the definitions of Decimal128Array and Decimal256Array

What changes are included in this PR?

Adds the ability to declare PrimitiveArray containing decimal data

Are there any user-facing changes?

No

@viirya
Copy link
Member

viirya commented Oct 6, 2022

There are many CI failures which look weird, but seems unrelated.

@viirya
Copy link
Member

viirya commented Oct 6, 2022

May need to re-trigger CI.

@tustvold tustvold added the arrow Changes to the arrow crate label Oct 6, 2022
@tustvold tustvold merged commit 37c8679 into apache:master Oct 6, 2022
@ursabot
Copy link

ursabot commented Oct 6, 2022

Benchmark runs are scheduled for baseline = c93ce39 and contender = 37c8679. 37c8679 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants