Split out arrow-row (#2594) #3375
Conversation
arrow-array/src/lib.rs
Outdated
| @@ -183,6 +183,25 @@ pub mod timezone; | |||
| mod trusted_len; | |||
| pub mod types; | |||
|
|
|||
| /// Options that define how sort kernels should behave | |||
There was a problem hiding this comment.
I moved this to arrow-array, so that arrow-row doesn't have to take a dependency on arrow-ord
There was a problem hiding this comment.
Maybe it could even be put in arrow_schema
| @@ -258,13 +258,12 @@ Rust Arrow Crates: | |||
| (cd arrow-array && cargo publish) | |||
| (cd arrow-select && cargo publish) | |||
| (cd arrow-cast && cargo publish) | |||
| (cd arrow-string && cargo publish) | |||
There was a problem hiding this comment.
Thanks -- I'll test them out on the next release
tustvold
force-pushed
the
split-out-arrow-row
branch
from
f04d6b4
to
9ad9d68
Compare
tustvold
force-pushed
the
split-out-arrow-row
branch
from
9ad9d68
to
5c6ce3a
Compare
arrow-array/src/lib.rs
Outdated
| @@ -183,6 +183,25 @@ pub mod timezone; | |||
| mod trusted_len; | |||
| pub mod types; | |||
|
|
|||
| /// Options that define how sort kernels should behave | |||
There was a problem hiding this comment.
Maybe it could even be put in arrow_schema
arrow-ord/src/sort.rs
Outdated
| @@ -27,6 +27,8 @@ use arrow_schema::{ArrowError, DataType, IntervalUnit, TimeUnit}; | |||
| use arrow_select::take::take; | |||
| use std::cmp::Ordering; | |||
|
|
|||
| pub use arrow_array::SortOptions; | |||
There was a problem hiding this comment.
👍 for backward compatibility
| @@ -258,13 +258,12 @@ Rust Arrow Crates: | |||
| (cd arrow-array && cargo publish) | |||
| (cd arrow-select && cargo publish) | |||
| (cd arrow-cast && cargo publish) | |||
| (cd arrow-string && cargo publish) | |||
There was a problem hiding this comment.
Thanks -- I'll test them out on the next release
|
Benchmark runs are scheduled for baseline = 0e4ddbf and contender = db9084e. db9084e is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?