Fix JSON Temporal Encoding of Multiple Batches #3924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doki23
commented
Mar 24, 2023
| } | ||
| }); | ||
| rows.iter_mut() | ||
| .take(row_count) |
doki23
force-pushed
the
batches_to_json_bugfix
branch
from
33d243d
to
e1d727d
Compare
tustvold
reviewed
Mar 24, 2023
tustvold
approved these changes
Mar 24, 2023
tustvold
changed the title
|
Thank you @doki23 -- very nice find |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes apache/datafusion#5635.
Rationale for this change
record_batches_to_json_rowsdoesn't process multi batches having temporal fields as expected.Are there any user-facing changes?
No