Cherry pick allow to read non-standard CSV to active_release #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor Reader::from_reader split into build_csv_reader, from_csv_reader add escape, quote, terminator arg to build_csv_reader * add escape,quote,terminator field to ReaderBuilder schema inference support for non-standard CSV add fn infer_file_schema_with_csv_options add fn infer_reader_schema_with_csv_options ReaderBuilder support for non-standard CSV add escape, quote, terminator field add fn with_escape, with_quote, with_terminator change ReaderBuilder::build for non-standard CSV * minimize API change * add tests add #[test] fn test_non_std_quote add #[test] fn test_non_std_escape add #[test] fn test_non_std_terminator * apply cargo fmt
Codecov Report
@@ Coverage Diff @@
## active_release #407 +/- ##
==================================================
+ Coverage 82.54% 82.58% +0.03%
==================================================
Files 162 162
Lines 44093 44194 +101
==================================================
+ Hits 36398 36499 +101
Misses 7695 7695
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatic cherry-pick of 1d72b26
Resolves #394