Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor lexico sort for future code reuse #423

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

jimexist
Copy link
Member

@jimexist jimexist commented Jun 8, 2021

Which issue does this PR close?

Re #428

Rationale for this change

the logic to sort a list of columns lexicographically given sort options was previously embedded within lexsort but this pull request changes to pull that part out to a generic struct for future code reuse.

This change is used in #424

What changes are included in this PR?

Are there any user-facing changes?

Copy link
Member

@jorgecarleitao jorgecarleitao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jimexist ! Ready to go in my opinion

@jimexist
Copy link
Member Author

jimexist commented Jun 8, 2021

Thanks @jimexist ! Ready to go in my opinion

not sure what i can do about the docker build failures

@codecov-commenter
Copy link

Codecov Report

Merging #423 (a0ba084) into master (18c804a) will decrease coverage by 0.00%.
The diff coverage is 92.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #423      +/-   ##
==========================================
- Coverage   82.64%   82.64%   -0.01%     
==========================================
  Files         162      162              
  Lines       44542    44549       +7     
==========================================
+ Hits        36813    36817       +4     
- Misses       7729     7732       +3     
Impacted Files Coverage Δ
arrow/src/compute/kernels/sort.rs 94.90% <92.00%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18c804a...a0ba084. Read the comment docs.

@jimexist
Copy link
Member Author

jimexist commented Jun 8, 2021

Thanks @jimexist ! Ready to go in my opinion

not sure what i can do about the docker build failures

seems like rebasing just solved this issue

@alamb
Copy link
Contributor

alamb commented Jun 8, 2021

seems like rebasing just solved this issue

I think that causes the tests to get re-run and thus if the error was due to some network glitch or something it will be solved by the re-execution

@alamb alamb merged commit a37dd4f into apache:master Jun 8, 2021
@jimexist jimexist deleted the refactor-lexico-sort branch June 9, 2021 00:55
alamb pushed a commit that referenced this pull request Jun 9, 2021
alamb added a commit that referenced this pull request Jun 10, 2021
Co-authored-by: Jiayu Liu <Jimexist@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants