Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add min and max kernel #4355

Closed
wants to merge 1 commit into from
Closed

add min and max kernel #4355

wants to merge 1 commit into from

Conversation

jimexist
Copy link
Member

@jimexist jimexist commented Jun 3, 2023

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jun 3, 2023
@tustvold
Copy link
Contributor

tustvold commented Jun 3, 2023

These kernels already exist in arrow-arithmetic I think?

Also FYI I'm working on a rework of the way we represent scalars in arrow-rs - see #1047

Edit: i see now the difference, I think this should be implemented in DF as a comparison kernel followed by a selection kernel. This will help keep code bloat down

https://docs.rs/arrow-select/latest/arrow_select/zip/fn.zip.html should do what you want

@jimexist
Copy link
Member Author

jimexist commented Jun 3, 2023

These kernels already exist in arrow-arithmetic I think?

Also FYI I'm working on a rework of the way we represent scalars in arrow-rs - see #1047

Edit: i see now the difference, I think this should be implemented in DF as a comparison kernel followed by a selection kernel. This will help keep code bloat down

https://docs.rs/arrow-select/latest/arrow_select/zip/fn.zip.html should do what you want

Thanks for the advice I have already done that in https://github.com/apache/arrow-datafusion/pull/6527/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compute::ord kernel for getting min and max of two scalar/array values
2 participants