Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: as_decimal256_array #4362

Closed
wants to merge 1 commit into from
Closed

feat: as_decimal256_array #4362

wants to merge 1 commit into from

Conversation

izveigor
Copy link
Contributor

@izveigor izveigor commented Jun 4, 2023

Which issue does this PR close?

Follow on to #1312

Rationale for this change

arrow-rs supports as_decimal_array, but does not as_decimal256_array.

What changes are included in this PR?

Yes

Are there any user-facing changes?

Yes

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jun 4, 2023
@tustvold
Copy link
Contributor

tustvold commented Jun 4, 2023 •
edited

as_decimal_array dates from before decimal arrays were primitive arrays, we should probably just deprecate and remove it. What do you think?

@izveigor
Copy link
Contributor Author

izveigor commented Jun 4, 2023

I think as_primitive_array::<Decimal128Type> is better method than as_decimal_array.

@izveigor izveigor closed this Jun 4, 2023
@izveigor izveigor mentioned this pull request Jun 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
arrow Changes to the arrow crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@izveigor @tustvold