feat: Support FixedSizedListArray for length kernel
#4520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weijun-H
force-pushed
the
Support-FixedSizedListArray-for-length-kernel
branch
from
ab3362d
to
b80afa0
Compare
tustvold
approved these changes
Jul 14, 2023
arrow-string/src/length.rs
Outdated
| let length_list = array.len(); | ||
| let buffer = Buffer::from_vec(vec![length; length_list]); | ||
|
|
||
| let data = unsafe { |
There was a problem hiding this comment.
Perhaps we could use PrimitiveArray::new here?
|
Hello, I just reviewed this PR and I have two suggestions:
Otherwise it looks good to me! |
tustvold
reviewed
Jul 19, 2023
arrow-string/src/length.rs
Outdated
| let length_list = array.len(); | ||
| let buffer = Buffer::from_vec(vec![length; length_list]); | ||
|
|
||
| let data: PrimitiveArray<T> = |
There was a problem hiding this comment.
Can we remove T and just use Int32Array?
| { | ||
| let array = array.as_any().downcast_ref::<FixedSizeListArray>().unwrap(); | ||
| let length_list = array.len(); | ||
| let buffer = Buffer::from_vec(vec![length; length_list]); |
There was a problem hiding this comment.
This assumes T::Native is i32
arrow-string/src/length.rs
Outdated
| let data: PrimitiveArray<T> = | ||
| PrimitiveArray::new(buffer.into(), array.nulls().cloned()); | ||
|
|
||
| make_array(data.into()) |
There was a problem hiding this comment.
Suggested change
| make_array(data.into()) | |
| Arc::new(data) |
arrow-string/src/length.rs
Outdated
| where | ||
| T: ArrowPrimitiveType, | ||
| { | ||
| let array = array.as_any().downcast_ref::<FixedSizeListArray>().unwrap(); |
There was a problem hiding this comment.
Suggested change
| let array = array.as_any().downcast_ref::<FixedSizeListArray>().unwrap(); | |
| let array = array.as_fixed_size_list(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4517
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?