Clarify GenericColumnReader::read_records #4540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
changed the title
tustvold
force-pushed
the
clarify-read-records
branch
from
425290f
to
f60c307
Compare
alamb
approved these changes
Jul 22, 2023
parquet/src/column/reader.rs
Outdated
| /// Read up to `num_records` returning the number of complete records, non-null | ||
| /// values and levels decoded | ||
| /// Read up to `num_records` whole records, returning the number of complete | ||
| /// records, non-null values and levels decoded. Records will not be partially read |
There was a problem hiding this comment.
What does "partially read" mean? Like does it mean that the a record will not be read unless there is sufficient data for all columns?
If so, maybe
Suggested change
| /// records, non-null values and levels decoded. Records will not be partially read | |
| /// records, non-null values and levels decoded. Records will not be partially read, | |
| /// they are only read as long as there is sufficient data for all columns available. |
There was a problem hiding this comment.
You only have a single column here, this is referring to record shredding of repeated values, will clarify further...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
#4376 (comment)
What changes are included in this PR?
Are there any user-facing changes?