Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Sync from arrow-flight example #4564

Merged
merged 3 commits into from
Jul 23, 2023

Conversation

tustvold
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

The Sync bounds are no longer necessary, and were causing user confusion

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate labels Jul 23, 2023
Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, out of curiosity, I cannot find previous PR related to remove Sync bounds requirement for the trait. Could you provide some info in the description?

@tustvold
Copy link
Contributor Author

tustvold commented Jul 23, 2023

#864

It was a long time ago 😅

@viirya
Copy link
Member

viirya commented Jul 23, 2023

#864

It was a long time ago 😅

Thank you. 😄

Co-authored-by: Liang-Chi Hsieh <viirya@gmail.com>
Co-authored-by: Liang-Chi Hsieh <viirya@gmail.com>
@viirya viirya merged commit 918959b into apache:master Jul 23, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants