support NullArray un arith/boolean kernel #4566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smiklos
commented
Jul 24, 2023
arrow-arith/src/boolean.rs
Outdated
| None => BooleanBuffer::new_unset(input.len()), | ||
| // NullArray has no nulls buffer yet all values are null | ||
| None => { | ||
| if input.data_type().equals_datatype(&DataType::Null) { |
There was a problem hiding this comment.
or should we check for input to be NullArray?
tustvold
approved these changes
Jul 24, 2023
arrow-arith/src/boolean.rs
Outdated
| None => BooleanBuffer::new_set(input.len()), | ||
| None => { | ||
| // NullArray has no nulls buffer yet all values are null | ||
| if input.data_type().equals_datatype(&DataType::Null) { |
There was a problem hiding this comment.
Suggested change
| if input.data_type().equals_datatype(&DataType::Null) { | |
| if input.data_type() == &DataType::Null { |
Could also possibly be lifted into the match expression
smiklos
force-pushed
the
airth_null_array_fix
branch
from
f4455e6
to
77c94db
Compare
|
Thank you |
xuchen-plus
pushed a commit
to lakesoul-io/arrow-rs
that referenced
this pull request
Jul 27, 2023
* support NullArray un arith/boolean kernel * prettify based on feedback
richox
pushed a commit
to richox/arrow-rs
that referenced
this pull request
Aug 3, 2023
* support NullArray un arith/boolean kernel * prettify based on feedback
richox
pushed a commit
to kwai/blaze
that referenced
this pull request
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4565.
Rationale for this change
What changes are included in this PR?
Since NullArray has no nulls buffer, we need to handle that case for
is_nullandis_not_nullto work correctlyAre there any user-facing changes?
Nope
Don't think so
Nope