Move chrono-tz arithmetic tests to integration #4571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
force-pushed
the
arrow-arithmetic-integration
branch
from
e073814
to
fa24fa4
Compare
alamb
approved these changes
Jul 26, 2023
| @@ -46,4 +46,3 @@ num = { version = "0.4", default-features = false, features = ["std"] } | |||
|
|
|||
| [features] | |||
| simd = ["arrow-array/simd"] | |||
| chrono-tz = ["arrow-array/chrono-tz"] | |||
There was a problem hiding this comment.
isn't this technically a breaking change for anyone using https://crates.io/crates/arrow-arith directly with this feature? I doubt anyone will notice, but I do think we should flag the PR as API change
There was a problem hiding this comment.
It hasn't been released yet
|
|
||
| [[test]] | ||
| name = "arithmetic" | ||
| required-features = ["chrono-tz"] |
There was a problem hiding this comment.
arithmetic is a fairly general name that only has timezone related tests now -- do you plan to move more tests there over time?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Removes the feature from the sub-crate, as it only gates tests
What changes are included in this PR?
Are there any user-facing changes?
No, the arrow-arith feature has not been released