Cleanup ArrayData::buffers #4583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
force-pushed
the
cleanup-array-data-buffers
branch
from
bd8b8e3
to
f060325
Compare
tustvold
commented
Jul 29, 2023
| pub use buffers::*; | ||
| /// A collection of [`Buffer`] | ||
| #[doc(hidden)] | ||
| pub type Buffers<'a> = &'a [Buffer]; |
There was a problem hiding this comment.
This makes the change backwards compatible
There was a problem hiding this comment.
Could you add a "deprecated" marker to it though so it can be removed in some future version?
crepererum
approved these changes
Aug 1, 2023
| pub use buffers::*; | ||
| /// A collection of [`Buffer`] | ||
| #[doc(hidden)] | ||
| pub type Buffers<'a> = &'a [Buffer]; |
There was a problem hiding this comment.
Could you add a "deprecated" marker to it though so it can be removed in some future version?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Originally added in #3783 as part of #1799. It was decided to not proceed with this in #3894 and so we should also cleanup this now unnecessary change
What changes are included in this PR?
Are there any user-facing changes?