Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Disabled Page Statistics (#4587) #4589

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

tustvold
Copy link
Contributor

Which issue does this PR close?

Closes #4587

Rationale for this change

#4567 fixed the reported bug, so this just adds an additional test

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the parquet Changes to the parquet crate label Jul 30, 2023
@tustvold tustvold changed the title Test disabling page index statistics (#4587) Test Disabled Page Statistics (#4587) Jul 30, 2023
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thank you @tustvold

I have a suggestion on comments, but otherwise this looks great

cc @MachaelLee

parquet/src/file/writer.rs Show resolved Hide resolved
parquet/src/file/writer.rs Outdated Show resolved Hide resolved
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
@tustvold tustvold merged commit ae0d82c into apache:master Aug 1, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(parquet): Disabling global statistics but enabling for particular column breaks reading
2 participants