fix(data): map type ID to child index before indexing a union child array #4598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kawadakk
changed the title
kawadakk
force-pushed
the
patches/fix-extend-union-dense
branch
3 times, most recently
from
abb5612
to
00edcba
Compare
tustvold
approved these changes
Jul 31, 2023
| @@ -48,14 +51,18 @@ pub(super) fn build_extend_dense(array: &ArrayData) -> Extend { | |||
| .extend_from_slice(&type_ids[start..start + len]); | |||
|
|
|||
| (start..start + len).for_each(|i| { | |||
| let type_id = type_ids[i] as usize; | |||
| let type_id = type_ids[i]; | |||
| let child_index = src_fields | |||
There was a problem hiding this comment.
Perhaps we could follow the approach used by UnionArray and compute this mapping once
https://github.com/apache/arrow-rs/blob/master/arrow-array/src/array/union_array.rs#L345
There was a problem hiding this comment.
Actually I implemented that optimization in an earlier version, but then realized that it might be counterproductive and excessively memory-intensive if the number of rows per input array is very low, and the number of input arrays is large (as in my use case). equal_dense is implemented in the naïve way as well.
kawadakk
force-pushed
the
patches/fix-extend-union-dense
branch
from
00edcba
to
ab724b1
Compare
|
Force-pushed a minor change to sate clippy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4578.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?