Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(select): handle NullArray in nullif #4635

Merged
merged 3 commits into from
Aug 3, 2023
Merged

fix(select): handle NullArray in nullif #4635

merged 3 commits into from
Aug 3, 2023

Conversation

kawadakk
Copy link
Contributor

@kawadakk kawadakk commented Aug 3, 2023

Which issue does this PR close?

Closes #4634.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Aug 3, 2023
tustvold
tustvold approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor nit, otherwise looks good. Thank you

arrow-select/src/nullif.rs Outdated Show resolved Hide resolved
@kawadakk kawadakk force-pushed the patches/fix-nullif-on-null-array branch from 8aba7fc to 189538e Compare August 3, 2023 05:45
@kawadakk kawadakk marked this pull request as draft August 3, 2023 05:45
@kawadakk @tustvold
test(select): remove as_null_array calls
e1962fe 
`dyn Array + '_` implements `PartialEq<impl Array>`, so the unwrapped
result of `nullif` can be compared against `NullArray` without
downcasting it first.

Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>
@kawadakk kawadakk force-pushed the patches/fix-nullif-on-null-array branch from 189538e to e1962fe Compare August 3, 2023 05:46
@kawadakk kawadakk marked this pull request as ready for review August 3, 2023 05:46
@tustvold tustvold merged commit c2b0aa5 into apache:master Aug 3, 2023
25 checks passed
@tustvold tustvold mentioned this pull request Aug 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viirya viirya viirya approved these changes

@tustvold tustvold tustvold approved these changes

@jackwener jackwener jackwener approved these changes

Assignees
No one assigned
Labels
arrow Changes to the arrow crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

arrow::compute::nullif panics if NullArray is provided
4 participants
@kawadakk @viirya @tustvold @jackwener