impl From<Vec<T>> for BufferBuilder and MutableBuffer
#4650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrobbel
force-pushed
the
builder-from-vec
branch
from
d6e74fa
to
ca4097a
Compare
|
If you merge master, the Ci should stop failing on SIMD nonsense |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None.
Rationale for this change
Both
BufferBuilderandMutableBufferprovide methods to convert from aVec. These implementations provide these conversions through theFromtrait.What changes are included in this PR?
From<Vec<T>>forBufferBuilderandMutableBuffer.MutableBuffer::from_vecas deprecated.Are there any user-facing changes?
Users are notified about the deprecations and can use the
std::converttrait to convert.