Use ArrayFormatter in cast kernel #4668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Aug 9, 2023
| @@ -622,21 +622,6 @@ where | |||
| Ok(Arc::new(array)) | |||
| } | |||
|
|
|||
| // cast the List array to Utf8 array | |||
| macro_rules! cast_list_to_string { | |||
There was a problem hiding this comment.
Changing to use ArrayFormatter is both faster, as it avoids intermediate string allocations, whilst also respecting format options
tustvold
commented
Aug 9, 2023
| @@ -8989,4 +8950,19 @@ mod tests { | |||
| fn test_const_options() { | |||
| assert!(CAST_OPTIONS.safe) | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_list_format_options() { | |||
viirya
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4669
Rationale for this change
What changes are included in this PR?
Follow up to #4666 uses ArrayFormatter in more places instead of custom logic
Are there any user-facing changes?