Fix equality of nested nullable FixedSizeBinary (#4637) #4670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Aug 9, 2023
| @@ -80,7 +80,7 @@ pub(super) fn fixed_binary_equal( | |||
| lhs_start + lhs_nulls.offset(), | |||
| len, | |||
| ); | |||
| let rhs_nulls = lhs.nulls().unwrap(); | |||
| let rhs_nulls = rhs.nulls().unwrap(); | |||
There was a problem hiding this comment.
It is actually remarkably hard to construct a test case to exercise this, kudos to @kawadakk for finding one. The reason it is hard is at this point the null masks have already been checked for equality, so you need one side to have a different start offset from the other, such that when correctly offset the null buffers compare equal, but the underlying null buffers themselves are not actually equal
…ed-nullable-fixed-size-binary-array
jackwener
approved these changes
Aug 10, 2023
alamb
reviewed
Aug 10, 2023
| @@ -80,7 +80,7 @@ pub(super) fn fixed_binary_equal( | |||
| lhs_start + lhs_nulls.offset(), | |||
| len, | |||
| ); | |||
| let rhs_nulls = lhs.nulls().unwrap(); | |||
| let rhs_nulls = rhs.nulls().unwrap(); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4637
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?