Fix MSRV CI #4671
Merged
Fix MSRV CI #4671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Aug 9, 2023
| - name: Downgrade object_store dependencies | ||
| working-directory: object_store | ||
| # Necessary because 1.30.0 updates MSRV to 1.63 | ||
| run: cargo update -p tokio --precise 1.29.1 |
There was a problem hiding this comment.
Other options would be to:
- Add a maximum version constraint
- Check in a lockfile
But both of these have obvious drawbacks, this seemed relatively unintrusive. Hopefully at some point cargo will add MSRV aware resolution so these sort of shenanigans will be handled automatically - rust-lang/cargo#9930
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
#4653 (comment)
Bumping the MSRV because the most recent version of a crate has bumped their MSRV does not improve user UX, but prevents users on older versions from compiling. This PR tweaks the CI to avoid this
Unfortunately there does not appear to be anything like consensus in the community on how best to handle this, rust-lang/libs-team#72, but perhaps once that consensus emerges we'll be able to follow that
What changes are included in this PR?
Are there any user-facing changes?