Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup some assert() with error propagation #4673

Merged
merged 2 commits into from
Aug 10, 2023
Merged

cleanup some assert() with error propagation #4673

merged 2 commits into from
Aug 10, 2023

Conversation

zeevm
Copy link
Contributor

@zeevm zeevm commented Aug 9, 2023

Replace a few assert() with Result error propagation for nicer behavior.

@github-actions github-actions bot added the parquet Changes to the parquet crate label Aug 9, 2023
tustvold
tustvold reviewed Aug 9, 2023
View reviewed changes
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these should be ok_or_else to avoid an eager string allocation, but otherwise looks good. Honestly not sure why clippy isn't complaining about this, it normally does...

parquet/src/file/serialized_reader.rs Outdated Show resolved Hide resolved
@tustvold tustvold merged commit 2139fa5 into apache:master Aug 10, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tustvold tustvold tustvold approved these changes

Assignees
No one assigned
Labels
parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zeevm @tustvold