Cleanup DynComparator (#2654) #4687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Aug 11, 2023
| ($t:ty, $key_type_lhs:expr, $left:expr, $right:expr) => { | ||
| cmp_dict_primitive::<$t>($key_type_lhs, $left, $right)? | ||
| }; | ||
| // TODO: Handle value nulls (#2687) |
There was a problem hiding this comment.
I'm still thinking about how best to handle this, we could pass SortOptions to build_compare, but this would likely imply making build_compare always handle nulls
There was a problem hiding this comment.
Yes, it provides a way for users of DynComparator to "see" these nulls
tustvold
commented
Aug 11, 2023
| let left = left.as_dictionary::<K>(); | ||
| let right = right.as_dictionary::<K>(); | ||
|
|
||
| let cmp = build_compare(left.values().as_ref(), right.values().as_ref())?; |
There was a problem hiding this comment.
This approach significantly reduces codegen and does not appear to impact performance
alamb
approved these changes
Aug 13, 2023
| ($t:ty, $key_type_lhs:expr, $left:expr, $right:expr) => { | ||
| cmp_dict_primitive::<$t>($key_type_lhs, $left, $right)? | ||
| }; | ||
| // TODO: Handle value nulls (#2687) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2654
Rationale for this change
Cleans up the code and improves the type coverage. I have confirmed that this does not impact any benchmarks
What changes are included in this PR?
Are there any user-facing changes?