Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix clippy warnings for rust 1.53 #470

Merged
merged 2 commits into from
Jun 19, 2021

Conversation

jimexist
Copy link
Member

@jimexist jimexist commented Jun 19, 2021

Which issue does this PR close?

fix clippy warnings for rust 1.53

Closes #467

Rationale for this change

fixing lint changes introduced by rust 1.53 so that master branch can be mergeable again

What changes are included in this PR?

  • fix assertion links
  • ignoring to_* naming convention lint warnings
  • prefer .collect than from

Are there any user-facing changes?

no user facing changes

@codecov-commenter
Copy link

Codecov Report

Merging #470 (bc16da9) into master (1f1c637) will increase coverage by 0.00%.
The diff coverage is 98.60%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #470   +/-   ##
=======================================
  Coverage   82.65%   82.66%           
=======================================
  Files         165      165           
  Lines       45563    45550   -13     
=======================================
- Hits        37662    37653    -9     
+ Misses       7901     7897    -4     
Impacted Files Coverage Δ
parquet/src/encodings/decoding.rs 92.47% <ø> (ø)
parquet/src/arrow/array_reader.rs 77.45% <57.14%> (+0.13%) ⬆️
arrow/src/json/reader.rs 84.02% <97.56%> (+0.11%) ⬆️
arrow/src/array/array_binary.rs 90.13% <100.00%> (ø)
arrow/src/array/array_boolean.rs 90.90% <100.00%> (ø)
arrow/src/array/array_dictionary.rs 84.56% <100.00%> (ø)
arrow/src/array/array_primitive.rs 94.70% <100.00%> (ø)
arrow/src/array/array_struct.rs 88.43% <100.00%> (ø)
arrow/src/array/array_union.rs 86.93% <100.00%> (ø)
arrow/src/array/builder.rs 85.90% <100.00%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f1c637...bc16da9. Read the comment docs.

Copy link
Member

@jorgecarleitao jorgecarleitao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot for the cleanup 👍

@Dandandan Dandandan merged commit 60fedf7 into apache:master Jun 19, 2021
@nevi-me
Copy link
Contributor

nevi-me commented Jun 19, 2021

Thanks, you beat me to this :)

@jimexist jimexist deleted the fix-clippy-warnings-for-1.53 branch June 19, 2021 15:36
@alamb
Copy link
Contributor

alamb commented Jun 20, 2021

Thank you @jimexist

@alamb alamb mentioned this pull request Jun 20, 2021
alamb pushed a commit to alamb/arrow-rs that referenced this pull request Jun 20, 2021
* fix clippy warnings for rust 1.53

* update readme
alamb added a commit that referenced this pull request Jun 20, 2021
* fix clippy warnings for rust 1.53 (#470)

* fix clippy warnings for rust 1.53

* update readme

* Fix up

Co-authored-by: Jiayu Liu <Jimexist@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clippy broken after upgrade to rust 1.53
6 participants