Remove rank kernels #4703
Merged
Remove rank kernels #4703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
These were added in #4609 and haven't yet been released. They were originally added with the view to using them for stable sort (#4545), however, my investigations showed this to not be a good approach. Additionally they are not hugely useful for implementing rank within the context of SQL, as implementing this efficiently requires tight integration between the windowing implementation and this "aggregate".
As such I'm not sure that these kernels are useful, and so would like to propose we don't include them just yet. They will remain in the git history should we wish to resurrect them in future
What changes are included in this PR?
Are there any user-facing changes?
No, these kernels are not yet released