Allow Constructing Non-Empty StructArray with no Fields (#4842) #4845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crepererum
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
I think one usecase could be if you map other data formats (like the bug report mentioned) that support this or if you project another struct type with an empty selection (something like select_fields(existing, [])). Now in both cases this is somewhat of a degenerative edge case, but might make downstream code simpler since they don't need another "if it's empty, do something else" clause.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4842
Rationale for this change
I'm not really sure of the use-case for this, but I guess it isn't prohibited by the specification...
What changes are included in this PR?
Are there any user-facing changes?