Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable new integration tests (#4828) #4862

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

tustvold
Copy link
Contributor

Which issue does this PR close?

Closes #4828

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@tustvold
Copy link
Contributor Author

This appears to be failing with

OSError: cannot load library '/__w/arrow-rs/arrow-rs/go/arrow/internal/cdata_integration/arrow_go_integration.so': /__w/arrow-rs/arrow-rs/go/arrow/internal/cdata_integration/arrow_go_integration.so: cannot open shared object file: No such file or directory. Additionally, ctypes.util.find_library() did not manage to locate a library called '/__w/arrow-rs/arrow-rs/go/arrow/internal/cdata_integration/arrow_go_integration.so'

@pitrou perhaps you might be able to advise here?

@pitrou
Copy link
Member

pitrou commented Sep 26, 2023

You need to enable the Go integration build like here:
https://github.com/apache/arrow/blob/5978729277e164c5b4dfd8916bb410b9e67a04c7/docker-compose.yml#L1735

      ARROW_GO_INTEGRATION: 1

@pitrou
Copy link
Member

pitrou commented Sep 26, 2023

Note this will enable the C Data Interface tests only for the supported implementations (C++ and Go currently).

To actually test the C Data Interface in Rust you'll need a bit more work.
See for example how C++ works here:
https://github.com/apache/arrow/blob/5978729277e164c5b4dfd8916bb410b9e67a04c7/dev/archery/archery/integration/tester_cpp.py#L146-L245

@tustvold tustvold merged commit b600e20 into apache:master Sep 27, 2023
31 checks passed
@tustvold
Copy link
Contributor Author

I've created #4867 as a follow up to enable the new tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable New Integration Tests
3 participants