Specialize Thrift Decoding (~40% Faster) (#4891) #4892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
force-pushed
the
specialize-thrift
branch
from
bbce13f
to
bbf3405
Compare
|
With the latest changes that switch to |
tustvold
commented
Oct 4, 2023
|
|
||
| let reader = remaining_metadata.as_ref().chain(&suffix[..suffix_len - 8]); | ||
| (read_metadata(reader)?, None) | ||
| let meta = fetch.fetch(metadata_start..file_size - 8).await?; |
There was a problem hiding this comment.
This does mean we re-read data, however, in almost all cases this will be irrelevant in the grand scheme of things.
Another option would be to concatenate the data here, but this might be less efficient, e.g. the underlying AsyncFileReader is just slicing a Bytes from memory.
tustvold
changed the title
|
I think it is important to note that this is related to making Parquet reading faster - as the connection between TCompactSliceInputProtocol and reading parquet metadata may not be obvious |
crepererum
reviewed
Oct 9, 2023
parquet/CONTRIBUTING.md
Outdated
| @@ -65,7 +65,7 @@ To compile and view in the browser, run `cargo doc --no-deps --open`. | |||
| To generate the parquet format (thrift definitions) code run from the repository root run | |||
|
|
|||
| ``` | |||
| $ docker run -v $(pwd):/thrift/src -it archlinux pacman -Sy --noconfirm thrift && wget https://raw.githubusercontent.com/apache/parquet-format/apache-parquet-format-2.9.0/src/main/thrift/parquet.thrift -O /tmp/parquet.thrift && thrift --gen rs /tmp/parquet.thrift && sed -i '/use thrift::server::TProcessor;/d' parquet.rs && mv parquet.rs parquet/src/format.rs | |||
| $ docker run -v $(pwd):/thrift/src -it archlinux pacman -Sy --noconfirm thrift && wget https://raw.githubusercontent.com/apache/parquet-format/master/src/main/thrift/parquet.thrift -O /tmp/parquet.thrift && thrift --gen rs /tmp/parquet.thrift && sed -i '/use thrift::server::TProcessor;/d' parquet.rs && sed -i 's/impl TSerializable for/impl crate::thrift::TSerializable for/g' parquet.rs && sed -i 's/fn write_to_out_protocol(&self, o_prot: &mut dyn TOutputProtocol)/fn write_to_out_protocol<T: TOutputProtocol>(\&self, o_prot: \&mut T)/g' parquet.rs && sed -i 's/fn read_from_in_protocol(i_prot: &mut dyn TInputProtocol)/fn read_from_in_protocol<T: TInputProtocol>(i_prot: \&mut T)/g' parquet.rs && mv parquet.rs parquet/src/format.rs | |||
There was a problem hiding this comment.
maybe place this into a script file?
Also I think the master commit should be pinned here, so that the output is reproducible.
alamb
reviewed
Oct 9, 2023
parquet/CONTRIBUTING.md
Outdated
| @@ -65,7 +65,7 @@ To compile and view in the browser, run `cargo doc --no-deps --open`. | |||
| To generate the parquet format (thrift definitions) code run from the repository root run | |||
|
|
|||
| ``` | |||
| $ docker run -v $(pwd):/thrift/src -it archlinux pacman -Sy --noconfirm thrift && wget https://raw.githubusercontent.com/apache/parquet-format/apache-parquet-format-2.9.0/src/main/thrift/parquet.thrift -O /tmp/parquet.thrift && thrift --gen rs /tmp/parquet.thrift && sed -i '/use thrift::server::TProcessor;/d' parquet.rs && mv parquet.rs parquet/src/format.rs | |||
| $ docker run -v $(pwd):/thrift/src -it archlinux pacman -Sy --noconfirm thrift && wget https://raw.githubusercontent.com/apache/parquet-format/master/src/main/thrift/parquet.thrift -O /tmp/parquet.thrift && thrift --gen rs /tmp/parquet.thrift && sed -i '/use thrift::server::TProcessor;/d' parquet.rs && sed -i 's/impl TSerializable for/impl crate::thrift::TSerializable for/g' parquet.rs && sed -i 's/fn write_to_out_protocol(&self, o_prot: &mut dyn TOutputProtocol)/fn write_to_out_protocol<T: TOutputProtocol>(\&self, o_prot: \&mut T)/g' parquet.rs && sed -i 's/fn read_from_in_protocol(i_prot: &mut dyn TInputProtocol)/fn read_from_in_protocol<T: TInputProtocol>(i_prot: \&mut T)/g' parquet.rs && mv parquet.rs parquet/src/format.rs | |||
There was a problem hiding this comment.
Somewhere we should encode the exact version of the thrift file that the currently checked in metadata came from, I think. By referring to master it will "depend" on when the script got run
crepererum
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4891
Rationale for this change
We aren't using
TCompactSliceInputProtocoland yet are already seeing non-trivial performance benefits from where we areWhat changes are included in this PR?
Are there any user-facing changes?