Mark OnCloseRowGroup Send #4893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Aah, it is because you want to hold the row group writer across a call to AsyncWrite to ObjectStorage... I guess that makes sense |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Enables apache/datafusion#7655
Rationale for this change
#4871 rolled back this change, but without it apache/datafusion#7655 encounters a compile time error since
OnCloseRowGroupis used across anawait.Apart from this change, apache/datafusion#7655 is working great against the current master branch of
arrow-rs.The compile error can be viewed here: https://github.com/apache/arrow-datafusion/actions/runs/6412903672/job/17410973730?pr=7655
What changes are included in this PR?
OnCloseRowGroup is marked Send.
Are there any user-facing changes?