Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused futures dependency from arrow-flight #528

Merged
merged 1 commit into from
Jul 9, 2021

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jul 6, 2021

Rationale for this change

I am trying to keep the arrow* dependency stack minimal and this dependency is only used in the examples

What changes are included in this PR?

Move dependencies to [dev-dependencies]

Are there any user-facing changes?

One less (explicit) dependency on crates.io -- it is likely that the futures crate is still a transitive dependency

@github-actions github-actions bot added the arrow-flight Changes to the arrow-flight crate label Jul 6, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #528 (d964619) into master (a1aace8) will not change coverage.
The diff coverage is n/a.

❗ Current head d964619 differs from pull request most recent head f64f3c1. Consider uploading reports for the commit f64f3c1 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #528   +/-   ##
=======================================
  Coverage   82.54%   82.54%           
=======================================
  Files         167      167           
  Lines       45956    45956           
=======================================
  Hits        37933    37933           
  Misses       8023     8023           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1aace8...f64f3c1. Read the comment docs.

@alamb alamb requested a review from nevi-me July 9, 2021 11:47
@nevi-me nevi-me merged commit 6538fe5 into apache:master Jul 9, 2021
@alamb
Copy link
Contributor Author

alamb commented Jul 9, 2021

Thanks @nevi-me !

@alamb alamb deleted the alamb/less-flight-dep branch July 9, 2021 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow-flight Changes to the arrow-flight crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants