Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix take kernel null handling on structs #531

Merged
merged 1 commit into from
Jul 9, 2021

Conversation

bjchambers
Copy link
Contributor

This closes #530.

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jul 9, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #531 (4342d28) into master (f1a831f) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #531      +/-   ##
==========================================
- Coverage   82.74%   82.59%   -0.16%     
==========================================
  Files         165      167       +2     
  Lines       45686    45975     +289     
==========================================
+ Hits        37805    37974     +169     
- Misses       7881     8001     +120     
Impacted Files Coverage Δ
arrow/src/compute/kernels/take.rs 94.72% <100.00%> (+0.64%) ⬆️
arrow/src/array/transform/boolean.rs 76.92% <0.00%> (-7.70%) ⬇️
parquet/src/encodings/encoding.rs 94.85% <0.00%> (-0.20%) ⬇️
parquet/src/arrow/arrow_writer.rs 97.98% <0.00%> (-0.07%) ⬇️
parquet/src/util/bit_packing.rs 99.96% <0.00%> (-0.01%) ⬇️
arrow-flight/src/utils.rs 0.00% <0.00%> (ø)
arrow/src/datatypes/mod.rs 100.00% <0.00%> (ø)
arrow/src/array/equal/variable_size.rs 100.00% <0.00%> (ø)
arrow-pyarrow-integration-testing/src/lib.rs 0.00% <0.00%> (ø)
...ng/src/flight_client_scenarios/integration_test.rs 0.00% <0.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1a831f...4342d28. Read the comment docs.

@alamb alamb merged commit f1fb2b1 into apache:master Jul 9, 2021
@alamb alamb added the bug label Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Take kernel doesn't handle nulls and structs correctly
4 participants