Improve debug output of Time32/Time64 arrays #5428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
approved these changes
Feb 26, 2024
Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>
Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>
|
Thanks, you are right, that looks better. |
|
I took the liberty of fixing the compilation errors in order to get this in |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5336 .
Rationale for this change
This change makes the debug output of Time32/Time64 arrays more descriptive.
What changes are included in this PR?
This PR changes the way Time32 and Time64 arrays are printed to debug. Previously, values that could not be cast to Time32 or Time64 had debug output values of
null. With this change, unsuccessful casts are included as errors in the debug output.Are there any user-facing changes?
Yes, the debug output for Time32 and Time64 arrays will change.