Remove unused import detected by nightly rust #5477
Conversation
github-actions
bot
added
parquet
|
hmm, the CI failed with errors like error: use of deprecated associated function It does not seem to relate to the changes |
|
Ok the latest CI uses chrono v0.4.35 while previous ci uses v0.4.34. It turns out that they release the new version a few hours ago and deprecated a few functions used by arrow-rs: https://github.com/chronotope/chrono/releases/tag/v0.4.35 |
|
Should be fixed if you merge master |
|
Can @tustvold you take a look at |
| @@ -441,8 +437,6 @@ mod lz4_codec { | |||
| } | |||
| } | |||
| } | |||
| #[cfg(any(feature = "lz4", test))] | |||
| pub use lz4_codec::*; | |||
There was a problem hiding this comment.
This removal seems incorrect?
There was a problem hiding this comment.
I tried with lz4 on and off, it seems that both are not used.
There was a problem hiding this comment.
But this is a public export when the experimental flag is enabled
There was a problem hiding this comment.
The compression.rs is not pub, so the pub use is scoped to this crate only, which is not being used. Do we want to make compression pub instead?
There was a problem hiding this comment.
It is public when the experimental feature is enabled
https://github.com/apache/arrow-rs/blob/master/parquet/src/lib.rs#L124
There was a problem hiding this comment.
Ah you are right! I didn't see two experimental macro there...
Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>
|
Thank you |
Which issue does this PR close?
Closes #5476.
Rationale for this change
With this pr been merged to nightly rust: rust-lang/rust#117772
The tracking for unused import has been improved, resulting numerous compiler warnings when building arrow-rs with nightly rust.
This PR simply remove them.
Note that there're many other linting problems as well in nightly rust, this pr only fix the problem with unused import, considering that the changes are quite large already.
What changes are included in this PR?
Are there any user-facing changes?