chore: update arrow-format #5502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ariesdevil
force-pushed
the
parquet
branch
2 times, most recently
from
e33311b
to
f628c3e
Compare
tustvold
reviewed
Mar 15, 2024
| @@ -32,8 +32,7 @@ use arrow_ipc::writer; | |||
| use arrow_schema::{DataType, Field, Fields, Schema, TimeUnit}; | |||
|
|
|||
| use crate::basic::{ | |||
| ConvertedType, LogicalType, Repetition, TimeUnit as ParquetTimeUnit, | |||
There was a problem hiding this comment.
The changes in this file seem unrelated to this PR?
There was a problem hiding this comment.
cargo formatted...
There was a problem hiding this comment.
There are also code changes mixed in though...
tustvold
previously approved these changes
Mar 15, 2024
3 tasks
| @@ -720,6 +726,33 @@ impl<'a> RecordBatch<'a> { | |||
| ) | |||
| } | |||
| } | |||
| /// Some types such as Utf8View are represented using a variable number of buffers. | |||
| /// For each such Field in the pre-ordered flattened logical schema, there will be | |||
| /// an entry in variadicBufferCounts to indicate the number of number of variadic | |||
There was a problem hiding this comment.
the number of number of
Redundant words.
There was a problem hiding this comment.
Should modify the fbs file https://github.com/apache/arrow-rs/blob/master/format/Message.fbs#L105
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #5506 .
Rationale for this change
Update arrow-format to new version.
What changes are included in this PR?
Update arrow-format to new version, include
ListView,LargeListView,BinaryViewandStringView.Are there any user-facing changes?
No