Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade object_store dependency to use chrono 0.4.34 #5578

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

l1nxy
Copy link
Contributor

@l1nxy l1nxy commented Apr 1, 2024

Which issue does this PR close?

The object store crate using the old chrono version,but the code is rewrite by #5479 . now the test in object store will be failed. so we need to upgrade the chrono version.

Rationale for this change

What changes are included in this PR?

Using the latest chrono.

Are there any user-facing changes?

@github-actions github-actions bot added the object-store Object Store Interface label Apr 1, 2024
@l1nxy l1nxy changed the title using latest choron using latest chrono Apr 1, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @l1nxy

I tested this locally like this

cd object_store
cargo update -p chrono --precise 0.4.31
cargo test

And the compilation indeed failed

error[E0599]: no function or associated item named `try_hours` found for struct `chrono::Duration` in the current scope
    --> src/lib.rs:1680:76
     |
1680 |             if_modified_since: Some(meta.last_modified - chrono::Duration::try_hours(10).unwrap()),
     |                                                                            ^^^^^^^^^
     |                                                                            |
     |                                                                            function or associated item not found in `Duration`
     |                                                                            help: there is an associated function with a similar name: `hours`

I then verified the test pass with version 0.4.34:

cargo update -p chrono --precise 0.4.34

@alamb alamb changed the title using latest chrono Upgrade object_store dependency to use chrono -0.4.34 Apr 1, 2024
@alamb alamb changed the title Upgrade object_store dependency to use chrono -0.4.34 Upgrade object_store dependency to use chrono 0.4.34 Apr 1, 2024
@alamb alamb merged commit 77a3132 into apache:master Apr 1, 2024
17 checks passed
@alamb
Copy link
Contributor

alamb commented Apr 1, 2024

Thanks again @l1nxy

@l1nxy l1nxy deleted the upgrade-chrono-version branch April 2, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
object-store Object Store Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants