Add GenericListViewArray for ListView & LargeListView
#5723
+953
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tustvold If you have time, I would appreciate it if you could help me review this PR. Thanks! |
tustvold
reviewed
Jun 11, 2024
Comment on lines
300
to
309
| /// Creates a [`GenericListViewArray`] from an iterator of primitive values | ||
| /// | ||
| pub fn from_iter_primitive<T, P, I>(_iter: I) -> Self | ||
| where | ||
| T: ArrowPrimitiveType, | ||
| P: IntoIterator<Item = Option<<T as ArrowPrimitiveType>::Native>>, | ||
| I: IntoIterator<Item = Option<P>>, | ||
| { | ||
| panic!("Not yet implemented, wait list view array builder to be implemented") | ||
| } |
There was a problem hiding this comment.
Perhaps we could just not provide this for now
tustvold
reviewed
Jun 11, 2024
| }; | ||
| let iter = std::iter::repeat(size).take(value.len()); | ||
| let mut offsets = Vec::with_capacity(iter.size_hint().0); | ||
| offsets.push(OffsetSize::usize_as(0)); |
tustvold
reviewed
Jun 11, 2024
Comment on lines
594
to
596
| .as_any() | ||
| .downcast_ref::<Int32Array>() | ||
| .unwrap() |
There was a problem hiding this comment.
Suggested change
| .as_any() | |
| .downcast_ref::<Int32Array>() | |
| .unwrap() | |
| .as_primitive::<Int32Type>() |
And the same elsewhere
tustvold
reviewed
Jun 11, 2024
Comment on lines
429
to
417
| acc = acc.checked_add(size).expect("usize overflow"); | ||
| offsets.push(OffsetSize::usize_as(acc)); |
There was a problem hiding this comment.
Suggested change
| acc = acc.checked_add(size).expect("usize overflow"); | |
| offsets.push(OffsetSize::usize_as(acc)); | |
| offsets.push(OffsetSize::usize_as(acc)); | |
| acc = acc.checked_add(size).expect("usize overflow"); |
tustvold
reviewed
Jun 11, 2024
| .iter() | ||
| .map(|x| x.map(|x| x.as_primitive::<Int32Type>().values().to_vec())) | ||
| .collect(); | ||
| assert_eq!(values, vec![Some(vec![1, 2, 3]), None, Some(vec![4, 5, 6])]) |
There was a problem hiding this comment.
Could we add tests of the offsets and sizes buffers, I think they're currently not quite correct
tustvold
reviewed
Jun 11, 2024
|
Thank you for taking the time to review my code despite being busy and unwell. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
A part of #5501
Rationale for this change
What changes are included in this PR?
Add GenericListViewArray implement
Are there any user-facing changes?