Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parquet-derive to repository README #5795

Merged
merged 4 commits into from
May 28, 2024

Conversation

konjac
Copy link
Contributor

@konjac konjac commented May 23, 2024

Which issue does this PR close?

Document refinement. Add parquet-derive to repository README

Closes #5751

Rationale for this change

See #5751

What changes are included in this PR?

Add parquet-derive to repository README. Also some minor refinements.

Are there any user-facing changes?

No. Only README changes.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @konjac -- this is a very nice contributuon. I found an issue with the link but otherwise looks great

README.md Outdated
| [`arrow-flight`] | Support for Arrow-Flight IPC protocol | [docs.rs](https://docs.rs/arrow-flight/latest) | [(README)][flight-readme] |
| [`object-store`] | Support for object store interactions (aws, azure, gcp, local, in-memory) | [docs.rs](https://docs.rs/object_store/latest) | [(README)][objectstore-readme] |
| [`parquet`] | Support for Parquet columnar file format | [docs.rs](https://docs.rs/parquet/latest) | [(README)][parquet-readme] |
| [`parquet_derive`]| A crate for deriving RecordWriter/RecordReader for arbitrary, simple structs| [docs.rs](https://docs.rs/parquet-derive/latest)| [(README)][parquet-derive-readme]|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I looked at this rendered page, the link doesn't appear to be working

https://github.com/konjac/arrow-rs/tree/add-parquet-derive-to-readme

Screenshot 2024-05-23 at 6 05 10 AM

Maybe there needs to be a space between the | 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the suggestion. The problem is the link below is using parquet-derive. New commit fixes this. Thank you!

@alamb
Copy link
Contributor

alamb commented May 28, 2024

Thanks @konjac - I took the liberty of running prettier and pushing the change to get this PR to pass CI

@alamb alamb merged commit 1ebd2a4 into apache:master May 28, 2024
9 checks passed
@alamb alamb added the documentation Improvements or additions to documentation label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parquet-derive should be included in repository README.
2 participants