Make ObjectStoreScheme public #5912
Conversation
| @@ -62,7 +62,7 @@ impl ObjectStoreScheme { | |||
| /// Create an [`ObjectStoreScheme`] from the provided [`Url`] | |||
| /// | |||
| /// Returns the [`ObjectStoreScheme`] and the remaining [`Path`] | |||
| fn parse(url: &Url) -> Result<(Self, Path), Error> { | |||
| pub fn parse(url: &Url) -> Result<(Self, Path), Error> { | |||
There was a problem hiding this comment.
You want to change this to return super::Error
There was a problem hiding this comment.
fixed in b9ca112 (by making error public not by returning super::Error)
| @@ -43,7 +43,7 @@ impl From<Error> for super::Error { | |||
|
|
|||
| /// Recognises various URL formats, identifying the relevant [`ObjectStore`] | |||
| #[derive(Debug, Eq, PartialEq)] | |||
| enum ObjectStoreScheme { | |||
| pub enum ObjectStoreScheme { | |||
There was a problem hiding this comment.
Maybe slap a #[non_exhaustive] on this, so that new variants can be added after a potential 1.0 release
|
It appears this PR also has a clippy CI failure that we need to fix before merging |
|
Hey, I will fix these issues up next week. Thanks for the review 😌 |
|
Would it be possible to add edit: also not a maintainer |
|
I took the liberty of adding additional docs / examples to this PR and merging up from main |
|
I'll plan to merge this in the next few days unless there are any other comments |
|
Thank you for merging this, and thank you for fixing it up for me! Sorry I didn’t manage to find the time. |
Which issue does this PR close?
Closes #5911.
Rationale for this change
ObjectStoreScheme::parsecontains non-trivial logic to resolve a given url into an object store scheme. Exposing this is useful, as it allows consumers to set up their own builders as they would like.What changes are included in this PR?
This just makes the types public.
Are there any user-facing changes?
The types become public.