WriteMultipart Abort on MultipartUpload::complete Error #5974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsdvh
commented
Jun 28, 2024
fsdvh
commented
Jun 28, 2024
|
Perhaps you could expand on what problem you're trying to address with these changes, perhaps by filing an issue? |
doing that now |
|
Added issue to discuss: #5977 |
|
Can we restore the abort methods and then I think this is good to go |
tustvold
changed the title
tustvold
changed the title
tustvold
approved these changes
Jul 2, 2024
tustvold
reviewed
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None
Rationale for this change
During a time of migration to a new object store (0.10+), I discovered that some of the api methods can be relaxed for more ergonomic usage
What changes are included in this PR?
Some methods of signature update, relaxing ownership constraints
Are there any user-facing changes?
Yes