Deduplicate strings/binarys when building view types #6005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XiangpengHao
changed the title
alamb
reviewed
Jul 6, 2024
There was a problem hiding this comment.
Thank you @XiangpengHao -- I think this PR looks great.
I think we need to extend the tests to cover 2 more cases (I left a comment) but otherwise it is ready to go
I left some suggestions that might improve the code, but I think they are optional
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
alamb
approved these changes
Jul 7, 2024
|
|
||
| let mut builder = StringViewBuilder::new() | ||
| .with_deduplicate_strings() | ||
| .with_block_size(value_1.len() as u32 * 2); // so that we will have multiple buffers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5910.
Rationale for this change
As discussed in #5910, when the array of strings have low number of unique values, it makes sense to deduplicate them while building it, especially when invoking
gcThis pr implements an optional mechanism to deduplicate the strings. This is turned off by default, as it may slow down building array if the array is mostly unique.
However, the
gcwill by default enable it, so that gc generates an optimal layout.What changes are included in this PR?
Are there any user-facing changes?