-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix parquet_derive with default features (and fix cargo publish
)
#837
Changes from all commits
3158947
ab69c80
83ab94d
bdc2ca8
7c32795
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -41,7 +41,7 @@ lz4 = { version = "1.23", optional = true } | |
zstd = { version = "0.9", optional = true } | ||
chrono = "0.4" | ||
num-bigint = "0.4" | ||
arrow = { path = "../arrow", version = "7.0.0-SNAPSHOT", optional = true, default-features = false } | ||
arrow = { path = "../arrow", version = "7.0.0-SNAPSHOT", optional = true, default-features = false, features = ["ipc"] } | ||
base64 = { version = "0.13", optional = true } | ||
clap = { version = "2.33.3", optional = true } | ||
serde_json = { version = "1.0", features = ["preserve_order"], optional = true } | ||
|
@@ -54,8 +54,8 @@ snap = "1.0" | |
brotli = "3.3" | ||
flate2 = "1.0" | ||
lz4 = "1.23" | ||
arrow = { path = "../arrow", version = "7.0.0-SNAPSHOT" } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this use of arrow with default features as a |
||
serde_json = { version = "1.0", features = ["preserve_order"] } | ||
arrow = { path = "../arrow", version = "7.0.0-SNAPSHOT", default-features = false, features = ["test_utils"] } | ||
|
||
[features] | ||
default = ["arrow", "snap", "brotli", "flate2", "lz4", "zstd", "base64"] | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
<!--- | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this follows the pattern of the tests in |
||
Licensed to the Apache Software Foundation (ASF) under one | ||
or more contributor license agreements. See the NOTICE file | ||
distributed with this work for additional information | ||
regarding copyright ownership. The ASF licenses this file | ||
to you under the Apache License, Version 2.0 (the | ||
"License"); you may not use this file except in compliance | ||
with the License. You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, | ||
software distributed under the License is distributed on an | ||
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
KIND, either express or implied. See the License for the | ||
specific language governing permissions and limitations | ||
under the License. | ||
--> | ||
|
||
This directory contains projects that use arrow as a dependency with | ||
various combinations of feature flags. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
|
||
[package] | ||
name = "defeault-features" | ||
description = "Models a user application of parquet_derive that uses no additional features of arrow" | ||
version = "0.1.0" | ||
edition = "2018" | ||
|
||
# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html | ||
|
||
[dependencies] | ||
parquet_derive = { path = "../../../../parquet_derive", version = "7.0.0-SNAPSHOT" } | ||
|
||
# Keep this out of the default workspace | ||
[workspace] |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
fn main() { | ||
println!("Hello, world!"); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the fix of the actual problem: the arrow writer requires the
ipc
feature which is no longer a default