[Minor] Fix clippy errors with new rust version (1.56) and float formatting with nightly #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
arrow
alamb
approved these changes
Oct 22, 2021
| } | ||
| make_array(unsafe { builder.build_unchecked() }) | ||
| } else if let DataType::LargeList(_) = *data_type { | ||
| if let DataType::List(_) | DataType::LargeList(_) = *data_type { |
|
@alamb I also fixed a test wrt. float formatting (I suppose that has been changed in a recent nightly). Please take another look, |
alamb
reviewed
Oct 22, 2021
| 255.0, | ||
| 65535.0, | ||
| 4294967295.0, | ||
| 18446744073709552000.0, | ||
| ]; | ||
| assert_eq!( | ||
| f64_expected, | ||
| get_cast_values::<Float64Type>(&f64_array, &DataType::Float64) |
There was a problem hiding this comment.
Rather than casting f64 to f64, converting it to strings (get_cast_values), and then reparsing, I wonder if it would be less error prone to just do the cast to F64Array directly?
alamb
approved these changes
Oct 22, 2021
alamb
changed the title
Codecov Report
@@ Coverage Diff @@
## master #845 +/- ##
==========================================
+ Coverage 82.64% 82.65% +0.01%
==========================================
Files 168 168
Lines 48088 48078 -10
==========================================
- Hits 39742 39741 -1
+ Misses 8346 8337 -9
Continue to review full report at Codecov.
|
Dandandan
changed the title
alamb
pushed a commit
that referenced
this pull request
Oct 23, 2021
…atting with nightly (#845) * Clippy fixes * Test formatting fixes * Test formatting fixes * Fixup
ovr
pushed a commit
to cube-js/arrow-rs
that referenced
this pull request
Apr 2, 2024
…atting with nightly (apache#845) * Clippy fixes * Test formatting fixes * Test formatting fixes * Fixup
ovr
pushed a commit
to cube-js/arrow-rs
that referenced
this pull request
Apr 2, 2024
…atting with nightly (apache#845) * Clippy fixes * Test formatting fixes * Test formatting fixes * Fixup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Fix the build by fixing the clippy lints and tests on nightly.
What changes are included in this PR?
Are there any user-facing changes?