Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick fix parquet_derive with default features (and fix cargo publish) #856

Merged
merged 3 commits into from Oct 25, 2021
Merged

Cherry pick fix parquet_derive with default features (and fix cargo publish) #856

merged 3 commits into from Oct 25, 2021

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Oct 24, 2021 •
edited

Manual cherry-pick of d6f3ef7

There were conflicts in parquet/Cargo.toml that I had to manually resolve

@alamb
fix parquet_derive with default features (and fix cargo publish) (#837
4226e09 
)

* Run all tests and do dry runs of cargo publish

* Add test for building parquet derive with default features'

* fix feature flags in parquet crate

* fixup rat

* fix default feature test
@github-actions github-actions bot added arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate parquet Changes to the parquet crate parquet-derive labels Oct 24, 2021
@alamb alamb changed the base branch from master to active_release October 24, 2021 10:45
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2021 •
edited

Codecov Report

Merging #856 (bc90765) into active_release (a721e00) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           active_release     #856   +/-   ##
===============================================
  Coverage           82.62%   82.62%           
===============================================
  Files                 168      168           
  Lines               48033    48033           
===============================================
  Hits                39687    39687           
  Misses               8346     8346

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a721e00...bc90765. Read the comment docs.

@alamb alamb merged commit 94cddca into active_release Oct 25, 2021
@alamb alamb deleted the cherry_pick_d6f3ef7c branch October 25, 2021 10:51
This was referenced Oct 29, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate parquet Changes to the parquet crate parquet-derive
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alamb @codecov-commenter