Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ilike comparitor #874

Merged
merged 2 commits into from
Nov 9, 2021
Merged

add ilike comparitor #874

merged 2 commits into from
Nov 9, 2021

Conversation

jwdeitch
Copy link
Contributor

@jwdeitch jwdeitch commented Oct 27, 2021

Which issue does this PR close?

Closes #873.

Are there any user-facing changes?

adding ilike comparison operator to bring more pgSQL compatibility ultimately into datafusion

@github-actions github-actions bot added the arrow Changes to the arrow crate label Oct 27, 2021
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @jwdeitch ! I plan to review this more carefully this weekend, but what I have seen so far looks very nice

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2021

Codecov Report

Merging #874 (baaad3a) into master (05eb63f) will decrease coverage by 0.12%.
The diff coverage is 85.79%.

❗ Current head baaad3a differs from pull request most recent head bf1c495. Consider uploading reports for the commit bf1c495 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #874      +/-   ##
==========================================
- Coverage   82.45%   82.33%   -0.13%     
==========================================
  Files         168      168              
  Lines       48175    48490     +315     
==========================================
+ Hits        39723    39923     +200     
- Misses       8452     8567     +115     
Impacted Files Coverage Δ
arrow-flight/src/arrow.flight.protocol.rs 0.00% <ø> (ø)
arrow/src/array/cast.rs 85.71% <ø> (ø)
arrow/src/array/transform/mod.rs 85.33% <ø> (-0.18%) ⬇️
arrow/src/csv/writer.rs 82.05% <ø> (-0.37%) ⬇️
arrow/src/error.rs 13.33% <0.00%> (ø)
...ng/src/flight_server_scenarios/auth_basic_proto.rs 0.00% <0.00%> (ø)
parquet/src/data_type.rs 76.84% <ø> (-0.48%) ⬇️
parquet/src/schema/parser.rs 85.11% <0.00%> (-1.26%) ⬇️
parquet/src/util/bit_packing.rs 99.96% <ø> (ø)
parquet/src/util/bit_util.rs 93.19% <ø> (+0.01%) ⬆️
... and 109 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05eb63f...bf1c495. Read the comment docs.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jwdeitch I think this looks great (including the tests).

We are sorting out the MIRI failures now that seem to be happening on master in CI -- #879 -- and once that is sorted we can merge this in

If you have the time / inclination, I think it would be really neat to reduce the copy/paste in the ilike, like, nlike,` etc kernels. I left a comment to this effect above

arrow/src/compute/kernels/comparison.rs Show resolved Hide resolved
@alamb
Copy link
Contributor

alamb commented Nov 9, 2021

@jwdeitch bf1c495 is a thing of beauty. Thank you so much for sticking with it. ❤️

I kicked off CI and plan to merge this PR when it passes

@alamb alamb merged commit ee1d164 into apache:master Nov 9, 2021
@alamb
Copy link
Contributor

alamb commented Nov 9, 2021

Thanks again @jwdeitch 👍

alamb pushed a commit that referenced this pull request Nov 20, 2021
* add ilike comparitor

* add ilike comparitor

Co-authored-by: Jordan Deitch <jdeitch@digitalocean.com>
alamb added a commit that referenced this pull request Nov 22, 2021
* add ilike comparitor

* add ilike comparitor

Co-authored-by: Jordan Deitch <jdeitch@digitalocean.com>

Co-authored-by: Jordan Deitch <jwdeitch@users.noreply.github.com>
Co-authored-by: Jordan Deitch <jdeitch@digitalocean.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add ilike string comparison operator
3 participants