-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ilike comparitor #874
add ilike comparitor #874
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @jwdeitch ! I plan to review this more carefully this weekend, but what I have seen so far looks very nice
Codecov Report
@@ Coverage Diff @@
## master #874 +/- ##
==========================================
- Coverage 82.45% 82.33% -0.13%
==========================================
Files 168 168
Lines 48175 48490 +315
==========================================
+ Hits 39723 39923 +200
- Misses 8452 8567 +115
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jwdeitch I think this looks great (including the tests).
We are sorting out the MIRI failures now that seem to be happening on master in CI -- #879 -- and once that is sorted we can merge this in
If you have the time / inclination, I think it would be really neat to reduce the copy/paste in the ilike
, like,
nlike,` etc kernels. I left a comment to this effect above
Thanks again @jwdeitch 👍 |
* add ilike comparitor * add ilike comparitor Co-authored-by: Jordan Deitch <jdeitch@digitalocean.com>
Which issue does this PR close?
Closes #873.
Are there any user-facing changes?
adding
ilike
comparison operator to bring more pgSQL compatibility ultimately into datafusion