Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some clippy warnings #896

Merged
merged 1 commit into from
Nov 2, 2021
Merged

fix some clippy warnings #896

merged 1 commit into from
Nov 2, 2021

Conversation

jimexist
Copy link
Member

@jimexist jimexist commented Nov 1, 2021

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added arrow Changes to the arrow crate parquet Changes to the parquet crate parquet-derive labels Nov 1, 2021
@@ -319,7 +319,7 @@ impl TreeBuilder {
/// Reader tree for record assembly
pub enum Reader {
// Primitive reader with type information and triplet iterator
PrimitiveReader(TypePtr, TripletIter),
PrimitiveReader(TypePtr, Box<TripletIter>),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reduce enum size

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2021

Codecov Report

Merging #896 (750203f) into master (06f730e) will increase coverage by 0.00%.
The diff coverage is 84.21%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #896   +/-   ##
=======================================
  Coverage   82.30%   82.30%           
=======================================
  Files         168      168           
  Lines       48031    48026    -5     
=======================================
- Hits        39533    39529    -4     
+ Misses       8498     8497    -1     
Impacted Files Coverage Δ
arrow/src/error.rs 13.33% <0.00%> (ø)
parquet/src/data_type.rs 76.84% <ø> (-0.11%) ⬇️
parquet/src/schema/parser.rs 85.11% <0.00%> (-0.21%) ⬇️
parquet/src/util/bit_packing.rs 99.96% <ø> (ø)
parquet/src/util/bit_util.rs 93.19% <ø> (ø)
parquet_derive/src/lib.rs 0.00% <0.00%> (ø)
arrow/src/compute/kernels/comparison.rs 92.63% <100.00%> (ø)
arrow/src/util/test_util.rs 90.90% <100.00%> (ø)
parquet/src/record/reader.rs 90.46% <100.00%> (ø)
parquet/src/util/hash_util.rs 95.65% <100.00%> (-0.13%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0892595...750203f. Read the comment docs.

@alamb
Copy link
Contributor

alamb commented Nov 1, 2021

Merged to master

@alamb alamb merged commit b79c600 into apache:master Nov 2, 2021
alamb pushed a commit that referenced this pull request Nov 9, 2021
alamb added a commit that referenced this pull request Nov 9, 2021
Co-authored-by: Jiayu Liu <Jimexist@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants