Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csv writer doc example mistype #904

Merged
merged 1 commit into from
Nov 3, 2021
Merged

Conversation

kingeasternsun
Copy link
Contributor

Which issue does this PR close?

Closes #903

Rationale for this change

document error

What changes are included in this PR?

fix document error

Are there any user-facing changes?

no

@github-actions github-actions bot added the arrow Changes to the arrow crate label Nov 2, 2021
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kingeasternsun

@alamb alamb added the documentation Improvements or additions to documentation label Nov 3, 2021
@alamb
Copy link
Contributor

alamb commented Nov 3, 2021

Integration test failure https://github.com/apache/arrow-rs/runs/4096796177?check_suite_focus=true is unrelated to changes in this PR

@codecov-commenter
Copy link

Codecov Report

Merging #904 (3929368) into master (2cf3178) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #904   +/-   ##
=======================================
  Coverage   82.30%   82.30%           
=======================================
  Files         168      168           
  Lines       48029    48029           
=======================================
+ Hits        39529    39531    +2     
+ Misses       8500     8498    -2     
Impacted Files Coverage Δ
arrow/src/csv/writer.rs 82.05% <ø> (ø)
arrow/src/array/transform/mod.rs 85.33% <0.00%> (+0.13%) ⬆️
arrow/src/datatypes/datatype.rs 65.36% <0.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cf3178...3929368. Read the comment docs.

@alamb
Copy link
Contributor

alamb commented Nov 3, 2021

Integration test failure is unrelated to this PR

@alamb alamb merged commit d5a4bd7 into apache:master Nov 3, 2021
alamb pushed a commit that referenced this pull request Nov 4, 2021
alamb added a commit that referenced this pull request Nov 5, 2021
Co-authored-by: kingeasternsun <kingeasternsun@gmail.com>
@kingeasternsun
Copy link
Contributor Author

Thank you @kingeasternsun

my pleasure 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

csv writer doc type error
3 participants