Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick Fix instances of UB that cause tests to not pass under miri to active_release #916

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Nov 4, 2021

Automatic cherry-pick of 4666b5f

* Fix unaligned access in bit-packing

* Fix creation of unaligned reference in murmur_hash2_64a

* Remove now-unnecessary unsafe

Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
@github-actions github-actions bot added the parquet Changes to the parquet crate label Nov 4, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #916 (c4b1101) into active_release (03d95e6) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

❗ Current head c4b1101 differs from pull request most recent head de1b2ac. Consider uploading reports for the commit de1b2ac to get more accurate results
Impacted file tree graph

@@                Coverage Diff                 @@
##           active_release     #916      +/-   ##
==================================================
- Coverage           82.45%   82.30%   -0.15%     
==================================================
  Files                 168      168              
  Lines               48175    48089      -86     
==================================================
- Hits                39725    39582     -143     
- Misses               8450     8507      +57     
Impacted Files Coverage Δ
parquet/src/util/bit_packing.rs 99.96% <ø> (ø)
parquet/src/util/bit_util.rs 93.19% <ø> (+0.01%) ⬆️
parquet/src/util/hash_util.rs 95.65% <100.00%> (-0.13%) ⬇️
arrow/src/array/transform/fixed_binary.rs 75.00% <0.00%> (-3.95%) ⬇️
parquet/src/schema/visitor.rs 67.10% <0.00%> (-2.64%) ⬇️
arrow/src/compute/kernels/cast_utils.rs 87.50% <0.00%> (-2.50%) ⬇️
parquet/src/encodings/decoding.rs 90.45% <0.00%> (-2.02%) ⬇️
arrow/src/datatypes/ffi.rs 70.85% <0.00%> (-2.02%) ⬇️
parquet/src/arrow/arrow_reader.rs 89.32% <0.00%> (-1.95%) ⬇️
arrow/src/ffi.rs 84.69% <0.00%> (-1.89%) ⬇️
... and 72 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03d95e6...de1b2ac. Read the comment docs.

@alamb alamb merged commit 3c69752 into active_release Nov 5, 2021
@alamb alamb deleted the cherry_pick_4666b5f4 branch November 5, 2021 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants