-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically retry failed MIRI runs to work around intermittent failures #922
Conversation
Codecov Report
@@ Coverage Diff @@
## master #922 +/- ##
=======================================
Coverage 82.30% 82.30%
=======================================
Files 168 168
Lines 48028 48028
=======================================
+ Hits 39529 39530 +1
+ Misses 8499 8498 -1
Continue to review full report at Codecov.
|
First run passed but also doesn't appear that the retry kicked in. Running again |
https://github.com/apache/arrow-rs/runs/4117071438?check_suite_focus=true also passed, but no retry kicked in. Will try again |
I want to see at least one PR where MIRI doesn't pass and is rerun to success prior to saying this is ready to merge |
OOh -- here is a run where MIRI crashed the first time but succeeded the second: https://github.com/apache/arrow-rs/runs/4118067989?check_suite_focus=true 🎉 Will keep rerunning and see how it goes |
…ures (#922) * Move MIRI checks into a shell script * add retry loop
Which issue does this PR close?
Closes #879
Rationale for this change
We are seeing intermittent failures while running MIRI checks on CI that are not reproducible locally and whose symptoms are consistent with miri being killed by the OOM killer (for example, perhaps github has over provisioned their runners so that the upper memory limit is not consistent). See here for details
When we manually rerun the MIRI run it often passes
What changes are included in this PR?
Automatically re-run MIRI up to 5 times looking for a clean run
Are there any user-facing changes?