Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick Fix validation for offsets of StructArrays to active_release #946

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Nov 12, 2021

Automatic cherry-pick of 078bc10

* reproduce validation error

* Fix validation bug

Co-authored-by: Ben Chambers <bjchambers@gmail.com>
@github-actions github-actions bot added the arrow Changes to the arrow crate label Nov 12, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #946 (a132be6) into active_release (dff1411) will increase coverage by 0.04%.
The diff coverage is 98.95%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           active_release     #946      +/-   ##
==================================================
+ Coverage           82.35%   82.39%   +0.04%     
==================================================
  Files                 168      168              
  Lines               48575    48668      +93     
==================================================
+ Hits                40005    40102      +97     
+ Misses               8570     8566       -4     
Impacted Files Coverage Δ
arrow/src/array/builder.rs 86.64% <80.00%> (+0.03%) ⬆️
arrow/src/array/array_binary.rs 93.41% <100.00%> (+0.28%) ⬆️
arrow/src/array/data.rs 80.72% <100.00%> (+1.16%) ⬆️
arrow/src/compute/kernels/take.rs 95.23% <100.00%> (+0.14%) ⬆️
arrow/src/array/transform/mod.rs 85.47% <0.00%> (+0.13%) ⬆️
parquet_derive/src/parquet_field.rs 66.21% <0.00%> (+0.22%) ⬆️
arrow/src/datatypes/datatype.rs 66.38% <0.00%> (+0.42%) ⬆️
arrow/src/error.rs 15.55% <0.00%> (+2.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1af9ca5...a132be6. Read the comment docs.

@alamb alamb merged commit 4037933 into active_release Nov 12, 2021
@alamb alamb deleted the cherry_pick_078bc10f branch November 22, 2021 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants