Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick Fix csv writing of timestamps to show timezone. to active_release #963

Merged
merged 1 commit into from Nov 22, 2021

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Nov 20, 2021

Automatic cherry-pick of bfc95be

* Write timestamps (in csvs) with timezone.

* More tests and more verbose naming.

* Please linter.

* Please clippy.

* Cleanup based on review feedback.
@github-actions github-actions bot added the arrow Changes to the arrow crate label Nov 20, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2021

Codecov Report

Merging #963 (2ae1ea6) into active_release (54023c8) will decrease coverage by 0.07%.
The diff coverage is 23.25%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           active_release     #963      +/-   ##
==================================================
- Coverage           82.38%   82.31%   -0.08%     
==================================================
  Files                 168      168              
  Lines               48668    48658      -10     
==================================================
- Hits                40097    40051      -46     
- Misses               8571     8607      +36     
Impacted Files Coverage Δ
arrow/src/compute/kernels/temporal.rs 96.07% <0.00%> (-1.28%) ⬇️
arrow/src/csv/writer.rs 72.03% <24.39%> (-10.03%) ⬇️
arrow/src/util/string_writer.rs 0.00% <0.00%> (-73.34%) ⬇️
arrow/src/util/display.rs 20.38% <0.00%> (-2.92%) ⬇️
parquet_derive/src/parquet_field.rs 65.98% <0.00%> (+0.22%) ⬆️
arrow/src/array/transform/mod.rs 85.47% <0.00%> (+0.27%) ⬆️
arrow/src/datatypes/datatype.rs 66.38% <0.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54023c8...2ae1ea6. Read the comment docs.

@alamb alamb merged commit 9f63502 into active_release Nov 22, 2021
@alamb alamb deleted the cherry_pick_bfc95be6 branch November 22, 2021 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants