Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI for latest nightly #970

Merged
merged 2 commits into from
Nov 23, 2021
Merged

Fix CI for latest nightly #970

merged 2 commits into from
Nov 23, 2021

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Nov 22, 2021

Which issue does this PR close?

Closes #969

Rationale for this change

CI jobs that use the nightly rust toolchain started failing
https://github.com/apache/arrow-rs/runs/4286145388?check_suite_focus=true

I think this is related to something included in the 2021-11-22 nightly release that makes the extern crate .. syntax not work anymore

What changes are included in this PR?

Remove some uses of extern crate

Are there any user-facing changes?

Small changes to examples

@github-actions github-actions bot added the arrow Changes to the arrow crate label Nov 22, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #970 (4726ebb) into master (b039cf4) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #970      +/-   ##
==========================================
- Coverage   82.32%   82.31%   -0.01%     
==========================================
  Files         168      168              
  Lines       48719    48719              
==========================================
- Hits        40107    40105       -2     
- Misses       8612     8614       +2     
Impacted Files Coverage Δ
arrow/src/datatypes/schema.rs 66.93% <ø> (ø)
arrow/src/datatypes/field.rs 53.37% <0.00%> (-0.31%) ⬇️
parquet_derive/src/parquet_field.rs 65.98% <0.00%> (-0.23%) ⬇️
arrow/src/array/transform/mod.rs 85.33% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b039cf4...4726ebb. Read the comment docs.

@jimexist jimexist merged commit d40cdc1 into apache:master Nov 23, 2021
@alamb alamb deleted the alamb/fix_ci branch November 23, 2021 12:15
alamb added a commit that referenced this pull request Nov 23, 2021
* Fix arrow doc examples

* more cleanup
alamb added a commit that referenced this pull request Nov 23, 2021
* Fix arrow doc examples

* more cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI Tests against nightly rust are failing
4 participants